Remove MultiCollectorWrapper and use MultiCollector in Lucene instead #19595
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Binlong Gao <[email protected]>
gaobinlong
requested review from
a team,
Bukhtawar,
CEHENKLE,
Rishikesh1159,
anasalkouz,
andrross,
ashking94,
cwperks,
dbwiddis,
gbbafna,
jed326,
kotwanikunal,
mch2,
msfroh,
owaiskazi19,
reta,
sachinpkale,
saratvemulapalli,
shwetathareja and
sohami
as code owners
Signed-off-by: Binlong Gao <[email protected]>
Contributor
|
❌ Gradle check result for db44cf9: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Contributor
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #19595 +/- ##
============================================
+ Coverage 73.06% 73.12% +0.05%
+ Complexity 70630 70604 -26
============================================
Files 5723 5722 -1
Lines 323513 323503 -10
Branches 46852 46851 -1
============================================
+ Hits 236384 236556 +172
+ Misses 68013 67879 -134
+ Partials 19116 19068 -48 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
reta
reviewed
Oct 10, 2025
server/src/main/java/org/opensearch/search/query/TopDocsCollectorContext.java
Outdated
Show resolved
Hide resolved
reta
reviewed
Oct 10, 2025
server/src/main/java/org/opensearch/search/query/TopDocsCollectorContext.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Binlong Gao <[email protected]>
Contributor
|
❕ Gradle check result for 6fd02e5: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
sandeshkr419
approved these changes
Oct 13, 2025
Member
sandeshkr419
left a comment
sandeshkr419
left a comment
There was a problem hiding this comment.
LGTM, just a minor code refactoring near the lines of code you are touching upon!
server/src/main/java/org/opensearch/search/query/TopDocsCollectorContext.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Binlong Gao <[email protected]>
Contributor
reta
reviewed
Oct 14, 2025
server/src/main/java/org/opensearch/search/query/TopDocsCollectorContext.java
Outdated
Show resolved
Hide resolved
reta
approved these changes
Oct 14, 2025
Signed-off-by: Binlong Gao <[email protected]>
reta
approved these changes
Oct 14, 2025
Contributor
peteralfonsi
pushed a commit
to peteralfonsi/OpenSearch
that referenced
this pull request
Oct 15, 2025
…opensearch-project#19595) * Remove MultiCollectorWrapper and use MultiCollector in Lucene instead Signed-off-by: Binlong Gao <[email protected]> * Modify change log Signed-off-by: Binlong Gao <[email protected]> * Optimize some code Signed-off-by: Binlong Gao <[email protected]> * pattern matching for instanceof Signed-off-by: Binlong Gao <[email protected]> * Remove redundant bracket Signed-off-by: Binlong Gao <[email protected]> --------- Signed-off-by: Binlong Gao <[email protected]>
This was referenced Oct 17, 2025
rgsriram
pushed a commit
to rgsriram/OpenSearch
that referenced
this pull request
Oct 18, 2025
…opensearch-project#19595) * Remove MultiCollectorWrapper and use MultiCollector in Lucene instead Signed-off-by: Binlong Gao <[email protected]> * Modify change log Signed-off-by: Binlong Gao <[email protected]> * Optimize some code Signed-off-by: Binlong Gao <[email protected]> * pattern matching for instanceof Signed-off-by: Binlong Gao <[email protected]> * Remove redundant bracket Signed-off-by: Binlong Gao <[email protected]> --------- Signed-off-by: Binlong Gao <[email protected]>
This was referenced Oct 22, 2025
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As this comment said, once MultiCollector.getCollectors() method in Lucene is declared as public, we can use that method directly rather than creating a new similar class, this PR replaces MultiCollectorWrapper with MultiCollector in Lucene, and removes MultiCollectorWrapper as it was internally used and won't be used anymore.
Related Issues
No issue.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.